LGTM with comments.
https://chromiumcodereview.appspot.com/9373023/diff/2001/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9373023/diff/2001/src/ast.h#newcode2520 src/ast.h:2520: VISIT_AND_RETURN(ModuleDeclaration, decl) You'll want to implement the matching Visit____ methods in AstConstructionVisitor to make this work. https://chromiumcodereview.appspot.com/9373023/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/9373023/diff/2001/src/hydrogen.cc#newcode6593 src/hydrogen.cc:6593: nit: we generally have two empty lines between top-level things. https://chromiumcodereview.appspot.com/9373023/diff/2001/src/prettyprinter.cc File src/prettyprinter.cc (right): https://chromiumcodereview.appspot.com/9373023/diff/2001/src/prettyprinter.cc#newcode84 src/prettyprinter.cc:84: nit: two empty lines https://chromiumcodereview.appspot.com/9373023/diff/2001/src/prettyprinter.cc#newcode770 src/prettyprinter.cc:770: same here https://chromiumcodereview.appspot.com/9373023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
