On 2012/02/13 13:14:58, Yang wrote:
http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc#newcode420
src/mips/builtins-mips.cc:420: __ Addu(t3, t3, kPointerSize);
you can skip the decrement later if you do the increment after the
smi-check.
http://codereview.chromium.org/9392001/diff/1/src/mips/builtins-mips.cc#newcode468
src/mips/builtins-mips.cc:468: __ Subu(t3, t3, Operand(kPointerSize));
this is the decrement I'm talking about in the previous comment.
Landed as http://codereview.chromium.org/9395003/
http://codereview.chromium.org/9392001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
