LGTM (with a few comments). Could you also add a short description to the CL
that we had diverging behavior between non-Crankshaft and Crankshaft code,
so
that it is clear that this CL just unifies our internal behavior?
https://chromiumcodereview.appspot.com/9402008/diff/1/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/9402008/diff/1/src/objects.cc#newcode11770
src/objects.cc:11770: // Clamp undefined to zero (default). All other
types have been
Comment no longer applies, it should say "clamp undefined to nan".
https://chromiumcodereview.appspot.com/9402008/diff/1/src/objects.cc#newcode11790
src/objects.cc:11790: // Clamp undefined to zero (default). All other
types have been
Likewise.
https://chromiumcodereview.appspot.com/9402008/diff/1/test/mjsunit/external-array.js
File test/mjsunit/external-array.js (right):
https://chromiumcodereview.appspot.com/9402008/diff/1/test/mjsunit/external-array.js#newcode324
test/mjsunit/external-array.js:324: for (var i = 0; i < 8; i++) {
Is there a particular reason the assignment has to be done in a loop?
https://chromiumcodereview.appspot.com/9402008/diff/1/test/mjsunit/external-array.js#newcode339
test/mjsunit/external-array.js:339:
store_float32_undefined(float32_array);
Is there a particular reason the store function is called twice here?
https://chromiumcodereview.appspot.com/9402008/diff/1/test/mjsunit/external-array.js#newcode343
test/mjsunit/external-array.js:343: for (var i = 0; i < 8; i++) {
Likewise.
https://chromiumcodereview.appspot.com/9402008/diff/1/test/mjsunit/external-array.js#newcode358
test/mjsunit/external-array.js:358:
store_float64_undefined(float64_array);
Likewise.
https://chromiumcodereview.appspot.com/9402008/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
