Feedback addressed, landing.
http://codereview.chromium.org/9402008/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/9402008/diff/1/src/objects.cc#newcode11770 src/objects.cc:11770: // Clamp undefined to zero (default). All other types have been On 2012/02/15 13:39:29, Michael Starzinger wrote:
Comment no longer applies, it should say "clamp undefined to nan".
Done. http://codereview.chromium.org/9402008/diff/1/src/objects.cc#newcode11790 src/objects.cc:11790: // Clamp undefined to zero (default). All other types have been On 2012/02/15 13:39:29, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/9402008/diff/1/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right): http://codereview.chromium.org/9402008/diff/1/test/mjsunit/external-array.js#newcode324 test/mjsunit/external-array.js:324: for (var i = 0; i < 8; i++) { On 2012/02/15 13:39:29, Michael Starzinger wrote:
Is there a particular reason the assignment has to be done in a loop?
Done. http://codereview.chromium.org/9402008/diff/1/test/mjsunit/external-array.js#newcode339 test/mjsunit/external-array.js:339: store_float32_undefined(float32_array); On 2012/02/15 13:39:29, Michael Starzinger wrote:
Is there a particular reason the store function is called twice here?
Done. http://codereview.chromium.org/9402008/diff/1/test/mjsunit/external-array.js#newcode343 test/mjsunit/external-array.js:343: for (var i = 0; i < 8; i++) { On 2012/02/15 13:39:29, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/9402008/diff/1/test/mjsunit/external-array.js#newcode358 test/mjsunit/external-array.js:358: store_float64_undefined(float64_array); On 2012/02/15 13:39:29, Michael Starzinger wrote:
Likewise.
Done. http://codereview.chromium.org/9402008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
