Revision: 10743
Author: [email protected]
Date: Mon Feb 20 00:41:13 2012
Log: Fix String.prototype.split for undefined separator.
[email protected]
TEST=test262/S15.5.4.14_A?_T?
Review URL: https://chromiumcodereview.appspot.com/9355005
http://code.google.com/p/v8/source/detail?r=10743
Modified:
/branches/bleeding_edge/src/string.js
/branches/bleeding_edge/test/test262/test262.status
=======================================
--- /branches/bleeding_edge/src/string.js Tue Jan 17 06:29:17 2012
+++ /branches/bleeding_edge/src/string.js Mon Feb 20 00:41:13 2012
@@ -588,11 +588,8 @@
limit = (IS_UNDEFINED(limit)) ? 0xffffffff : TO_UINT32(limit);
// ECMA-262 says that if separator is undefined, the result should
- // be an array of size 1 containing the entire string. SpiderMonkey
- // and KJS have this behavior only when no separator is given. If
- // undefined is explicitly given, they convert it to a string and
- // use that. We do as SpiderMonkey and KJS.
- if (%_ArgumentsLength() === 0) {
+ // be an array of size 1 containing the entire string.
+ if (IS_UNDEFINED(separator)) {
return [subject];
}
=======================================
--- /branches/bleeding_edge/test/test262/test262.status Fri Feb 17 05:35:00
2012
+++ /branches/bleeding_edge/test/test262/test262.status Mon Feb 20 00:41:13
2012
@@ -57,11 +57,6 @@
15.2.3.7-6-a-285: FAIL
# Unanalyzed failures:
-S15.5.4.14_A1_T6: FAIL
-S15.5.4.14_A1_T7: FAIL
-S15.5.4.14_A1_T8: FAIL
-S15.5.4.14_A1_T9: FAIL
-S15.5.4.14_A2_T7: FAIL
S15.10.2.12_A1_T1: FAIL
S15.10.2.12_A2_T1: FAIL
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev