LGTM
http://codereview.chromium.org/9401008/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1285 src/parser.cc:1285: Consume(Token::PERIOD); Can be shortened to while (Check(Token::PERIOD)) { which does the test and consume. http://codereview.chromium.org/9401008/diff/1/src/parser.cc#newcode1310 src/parser.cc:1310: Handle<String> symbol = GetSymbol(ok); Should this continue after an error? I.e., shouldn't it rather be ... GetSymbol(CHECK_OK); ? Or perhaps check the token type before doing the GetSymbol on it, so you don't try to GetSymbol on a non-identifier/non-string value. The current code doing all the extra checking on *ok seems less readable than possible, http://codereview.chromium.org/9401008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
