LGTM.
Please make sure that the new cases are covered by our unit tests and add
one if
they are not covered already.
https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc#newcode5324
src/hydrogen.cc:5324: left, Representation::Double(), false, true);
Please break like this and comment the boolean paramters:
HChange(left,
Representation::Double(),
false,
true);
https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc#newcode5330
src/hydrogen.cc:5330: right, Representation::Double(), false, true);
Also here: Short same-line comment for the boolean paramters.
https://chromiumcodereview.appspot.com/9372021/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
