LGTM with comments addressed.
https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc#newcode11053 test/cctest/test-api.cc:11053: const char* a = "a"; static const char* kPropertyA https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc#newcode11054 test/cctest/test-api.cc:11054: const char* h = "h"; static const char* kPropertyB https://chromiumcodereview.appspot.com/9425048/diff/1/test/cctest/test-api.cc#newcode11063 test/cctest/test-api.cc:11063: return !(strcmp(a, buf) == 0 || strcmp(h, buf) == 0); ->IsEqualTo(CStrVector(kPropertyA)) ? https://chromiumcodereview.appspot.com/9425048/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
