PTAL. Added new patch set.
https://chromiumcodereview.appspot.com/9426032/diff/1/src/jsregexp.cc File src/jsregexp.cc (right): https://chromiumcodereview.appspot.com/9426032/diff/1/src/jsregexp.cc#newcode3600 src/jsregexp.cc:3600: static const int kSpaceRangeCount = 22; On 2012/02/20 16:03:19, rossberg wrote:
Not your code, but can't we compute this constant using ARRAY_SIZE?
Done. https://chromiumcodereview.appspot.com/9426032/diff/1/test/sputnik/sputnik.status File test/sputnik/sputnik.status (right): https://chromiumcodereview.appspot.com/9426032/diff/1/test/sputnik/sputnik.status#newcode134 test/sputnik/sputnik.status:134: S15.10.2.12_A2_T1: PASS || FAIL_OK On 2012/02/20 13:55:30, Lasse Reichstein Nielsen wrote:
If you can, make it either PASS or FAIL_OK. This way, all you test is whether it crashes.
Done. Sputnik will be deprecated (and replaced by test262) this quarter anyways, so I don't actually care much about keeping this file clean. https://chromiumcodereview.appspot.com/9426032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
