LGTM with a comment
https://chromiumcodereview.appspot.com/9395087/diff/6001/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/9395087/diff/6001/src/profile-generator.cc#newcode3432 src/profile-generator.cc:3432: MaxDecimalDigitsIn<sizeof(long long)>::kUnsigned + 1; // NOLINT I will change "long long" to "T" (and update the comment), because "long long" isn't the part of ISO 1998 C++ standard and hence doesn't compile in a standalone V8. If you are OK with this, I'll submit your change. https://chromiumcodereview.appspot.com/9395087/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
