Reviewers: Michael Starzinger,
Description:
Simplified return values a bit when defining accessors.
Please review this at http://codereview.chromium.org/9467005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
17ef8dfd2308a39c87a41c76ac72e314ca9b302e..25e4fa9db9d64c49dda762d2e8373ae6b49202ea
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4450,10 +4450,7 @@ MaybeObject*
JSObject::DefineElementAccessor(uint32_t index,
}
accessors->set(is_getter, fun);
- { MaybeObject* maybe_ok = SetElementCallback(index, accessors,
attributes);
- if (maybe_ok->IsFailure()) return maybe_ok;
- }
- return GetHeap()->undefined_value();
+ return SetElementCallback(index, accessors, attributes);
}
@@ -4478,10 +4475,7 @@ MaybeObject*
JSObject::DefinePropertyAccessor(String* name,
}
copy->set(is_getter, fun);
// Use set to update attributes.
- { MaybeObject* maybe_ok = SetPropertyCallback(name, copy,
attributes);
- if (maybe_ok->IsFailure()) return maybe_ok;
- }
- return GetHeap()->undefined_value();
+ return SetPropertyCallback(name, copy, attributes);
}
}
}
@@ -4492,10 +4486,7 @@ MaybeObject*
JSObject::DefinePropertyAccessor(String* name,
}
accessors->set(is_getter, fun);
- { MaybeObject* maybe_ok = SetPropertyCallback(name, accessors,
attributes);
- if (maybe_ok->IsFailure()) return maybe_ok;
- }
- return GetHeap()->undefined_value();
+ return SetPropertyCallback(name, accessors, attributes);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
