Here is the link to the same CL on chromium codereview: http://codereview.chromium.org/9447052/
On Fri, Feb 24, 2012 at 10:29 AM, <[email protected]> wrote: > On 2012/02/24 08:43:29, dvyukov wrote: > >> On 2012/02/23 12:26:44, fschneider wrote: >> > Please make sure that the base URL of your changes in the future >> > always points > >> > to the bleeding_edge branch >> > (https://v8.googlecode.com/**svn/branches/bleeding_edge<https://v8.googlecode.com/svn/branches/bleeding_edge>) >> and not to >> > trunk. > >> > >> > To me it would seems cleaner to reduce callback.h to the minimum >> > required for > >> > the purpose of static initialization. >> > > Well, actually if we limit callbacks to "void (*init_func)(Arg*)" >> > (instead of > >> "void (*init_func)(Arg)" which is IMVHO quite reasonable, then we can >> > remove > >> callbacks.h entirely. The implementation will just cast "void >> (*init_func)(Arg*)" to "void (*init_func)(void*)" and Arg* to void* >> > and then > >> pass it to non-templated implementation. >> > > I removed callback.h. > > http://codereview.appspot.com/**5687064/<http://codereview.appspot.com/5687064/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
