Revision: 10824
Author:   [email protected]
Date:     Fri Feb 24 05:04:16 2012
Log:      Simplified return values a bit when defining accessors.

Review URL: https://chromiumcodereview.appspot.com/9467005
http://code.google.com/p/v8/source/detail?r=10824

Modified:
 /branches/bleeding_edge/src/objects.cc

=======================================
--- /branches/bleeding_edge/src/objects.cc      Thu Feb 23 04:12:28 2012
+++ /branches/bleeding_edge/src/objects.cc      Fri Feb 24 05:04:16 2012
@@ -4450,10 +4450,7 @@
   }
   accessors->set(is_getter, fun);

- { MaybeObject* maybe_ok = SetElementCallback(index, accessors, attributes);
-    if (maybe_ok->IsFailure()) return maybe_ok;
-  }
-  return GetHeap()->undefined_value();
+  return SetElementCallback(index, accessors, attributes);
 }


@@ -4478,10 +4475,7 @@
         }
         copy->set(is_getter, fun);
         // Use set to update attributes.
- { MaybeObject* maybe_ok = SetPropertyCallback(name, copy, attributes);
-          if (maybe_ok->IsFailure()) return maybe_ok;
-        }
-        return GetHeap()->undefined_value();
+        return SetPropertyCallback(name, copy, attributes);
       }
     }
   }
@@ -4492,10 +4486,7 @@
   }
   accessors->set(is_getter, fun);

- { MaybeObject* maybe_ok = SetPropertyCallback(name, accessors, attributes);
-    if (maybe_ok->IsFailure()) return maybe_ok;
-  }
-  return GetHeap()->undefined_value();
+  return SetPropertyCallback(name, accessors, attributes);
 }


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to