lgtm
https://chromiumcodereview.appspot.com/9460004/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/9460004/diff/1/include/v8.h#newcode3853 include/v8.h:3853: static const int kJSObjectType = 0xa9; I love this... https://chromiumcodereview.appspot.com/9460004/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/9460004/diff/1/src/objects.h#newcode6440 src/objects.h:6440: class AliasedArgumentsEntry: public Struct { Maybe add a comment explaining the role of this type. https://chromiumcodereview.appspot.com/9460004/diff/1/test/mjsunit/object-define-property.js File test/mjsunit/object-define-property.js (right): https://chromiumcodereview.appspot.com/9460004/diff/1/test/mjsunit/object-define-property.js#newcode1077 test/mjsunit/object-define-property.js:1077: })(0); You could have another test that checks that everything still works correctly when the arguments object escapes its owner function and is modified elsewhere. https://chromiumcodereview.appspot.com/9460004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
