Reviewers: Vyacheslav Egorov,
Message:
On 2012/02/17 11:31:46, Vyacheslav Egorov wrote:
http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py
File tools/gen-postmortem-metadata.py (right):
http://codereview.chromium.org/9361008/diff/1/tools/gen-postmortem-metadata.py#newcode119
tools/gen-postmortem-metadata.py:119: 'Code, instruction_start, int,
kHeaderSize',
instruction_start is of type Address not of type int
Thanks for the review. Although the type is technically "Address", as far
as the
debugger is concerned it's just an integer pointer. It probably should be
"uintptr_t" like FixedArray's "data" field. Can you make this change when
you
patch it in or should I submit a new review?
Thanks,
Dave
Description:
Add Code-related fields to postmortem metadata
Please review this at http://codereview.chromium.org/9361008/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/gen-postmortem-metadata.py
Index: tools/gen-postmortem-metadata.py
===================================================================
--- tools/gen-postmortem-metadata.py (revision 10626)
+++ tools/gen-postmortem-metadata.py (working copy)
@@ -115,6 +115,9 @@
'ConsString, second, String, kSecondOffset',
'ExternalString, resource, Object, kResourceOffset',
'SeqAsciiString, chars, char, kHeaderSize',
+ 'SharedFunctionInfo, code, Code, kCodeOffset',
+ 'Code, instruction_start, int, kHeaderSize',
+ 'Code, instruction_size, int, kInstructionSizeOffset',
];
#
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
