Revision: 10838
Author: [email protected]
Date: Mon Feb 27 02:43:57 2012
Log: Disable for-in support in Crankshaft while crashes and
regressions are being investigated.
[email protected]
Review URL: https://chromiumcodereview.appspot.com/9463049
http://code.google.com/p/v8/source/detail?r=10838
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Wed Feb 22 07:18:29 2012
+++ /branches/bleeding_edge/src/flag-definitions.h Mon Feb 27 02:43:57 2012
@@ -169,6 +169,9 @@
DEFINE_bool(optimize_closures, true, "optimize closures")
DEFINE_int(loop_weight, 1, "loop weight for representation inference")
+DEFINE_bool(optimize_for_in, false,
+ "optimize functions containing for-in loops")
+
// Experimental profiler changes.
DEFINE_bool(experimental_profiler, false, "enable all profiler
experiments")
DEFINE_bool(watch_ic_patching, false, "profiler considers IC stability")
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Fri Feb 24 00:46:10 2012
+++ /branches/bleeding_edge/src/hydrogen.cc Mon Feb 27 02:43:57 2012
@@ -3242,6 +3242,10 @@
ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor());
+ if (!FLAG_optimize_for_in) {
+ return Bailout("ForInStatement optimization is disabled");
+ }
+
if (!stmt->each()->IsVariableProxy() ||
!stmt->each()->AsVariableProxy()->var()->IsStackLocal()) {
return Bailout("ForInStatement with non-local each variable");
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev