Reviewers: Jakob, danno, Paul Lind, kisg,
Message:
Building and testing v8 on MIPS requires the following patches to be landed
as
well:
http://codereview.chromium.org/9453009/
http://codereview.chromium.org/9447015/
Description:
MIPS: Profiler experiments: Fix debugger in the presence of
self-optimization
headers
Port r10834 (0ce8cc524).
Note: this commit is a simple fix-up for
FullCodeGenerator::self_optimization_header_size().
BUG=
TEST=
Please review this at http://codereview.chromium.org/9466050/
Affected files:
M src/mips/full-codegen-mips.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
c8239e32461c4fe675ff2aae2806e397a765fb71..312f49b60a2333a55d7752427932f677f416a4f0
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -120,7 +120,7 @@ class JumpPatchSite BASE_EMBEDDED {
int FullCodeGenerator::self_optimization_header_size() {
- return 0; // TODO(jkummerow): determine correct value.
+ return 11 * Instruction::kInstrSize;
}
@@ -164,7 +164,7 @@ void FullCodeGenerator::Generate() {
Handle<Code> compile_stub(
isolate()->builtins()->builtin(Builtins::kLazyRecompile));
__ Jump(compile_stub, RelocInfo::CODE_TARGET, eq, a3,
Operand(zero_reg));
- ASSERT(masm_->pc_offset() == self_optimization_header_size());
+ ASSERT_EQ(masm_->pc_offset(), self_optimization_header_size());
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
