On 2012/02/27 11:57:25, alexeif wrote:
Thanks for the review. Added it back.
https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (left):
https://chromiumcodereview.appspot.com/9466014/diff/1/test/cctest/test-heap-profiler.cc#oldcode110
test/cctest/test-heap-profiler.cc:110: CHECK(det.has_A2);
On 2012/02/24 23:19:50, Mikhail Naganov (Chromium) wrote:
> I'm against removing this code. It checks that A2, B2 and C2 functions
are
> reachable from the global object. Just a sanity check that we don't
produce
> broken snapshots. Please restore it or replace with an equivalent.
Done.
Alexei, I'm getting test failures with your patch. Can you please re-check?
Almost in every test from cctest/heap-profiler (debug flavour):
running tests for x64.debug
=== debug test-heap-profiler BoundFunctionInSnapshot ===
Path: cctest/test-heap-profiler/BoundFunctionInSnapshot
#
# Fatal error in ../src/profile-generator.h, line 564
# CHECK(!painted_) failed
#
https://chromiumcodereview.appspot.com/9466014/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
