Thanks for the comments, please take another look.
http://codereview.chromium.org/9464054/diff/1/src/isolate.cc File src/isolate.cc (right): http://codereview.chromium.org/9464054/diff/1/src/isolate.cc#newcode1782 src/isolate.cc:1782: stub_cache_ = new (calloc(1, sizeof(StubCache))) StubCache(this); On 2012/02/27 13:03:29, Sven Panne wrote:
I think we can remove this line completely and replace it with
something
below...
Unfortunately, builtins.SetUp() assumes that stub_cache->isolate_ is initialized. http://codereview.chromium.org/9464054/diff/1/src/isolate.cc#newcode1839 src/isolate.cc:1839: stub_cache_->Initialize(create_heap_objects); On 2012/02/27 13:03:29, Sven Panne wrote:
Remove this line.
Done. http://codereview.chromium.org/9464054/diff/1/src/isolate.cc#newcode1844 src/isolate.cc:1844: stub_cache_->Initialize(true); On 2012/02/27 13:03:29, Sven Panne wrote:
I think we can move this Initialize past the condition and replace it
with a
"stub_cache_ = new StubCache(this);" there, because I doubt that the uninitialized StubCache can be used before this point, anyway.
Moved Initialize(). http://codereview.chromium.org/9464054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
