Addressed comments. Added new patch set. Rebased. Landed.
https://chromiumcodereview.appspot.com/9304001/diff/25001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/9304001/diff/25001/src/hydrogen.cc#newcode5551 src/hydrogen.cc:5551: Pop(); On 2012/02/27 15:06:02, Vyacheslav Egorov wrote:
I think we can replace receiver with function with
SetExpressionStackAt() and
then use PreProcessCall to do heavy lifting with HPushArgument.
Done. Made PreProcessCall more templatey. https://chromiumcodereview.appspot.com/9304001/diff/25001/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://chromiumcodereview.appspot.com/9304001/diff/25001/src/mips/lithium-codegen-mips.cc#newcode4251 src/mips/lithium-codegen-mips.cc:4251: __ li(a0, Operand(constructor)); On 2012/02/27 15:06:02, Vyacheslav Egorov wrote:
consider using LoadHeapObject/PushHeapObject just to be safe in case
if we start
inlining constructors that are in new space (all architectures).
Done (on ARM and MIPS). https://chromiumcodereview.appspot.com/9304001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
