I'd also like to have a cctest for the new BitRange class. Otherwise LGTM.
https://chromiumcodereview.appspot.com/9156001/diff/2002/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/9156001/diff/2002/src/hydrogen-instructions.cc#newcode1317 src/hydrogen-instructions.cc:1317: result.ExtendRange(&lower, &upper); I'd simplify this by propagating the inputs kMaxInt and kMinInt into ExtendRange and change it to return a Range object directy: return result.ExtendRange(); https://chromiumcodereview.appspot.com/9156001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
