Reviewers: Sven Panne,
Message:
PTAL.
Description:
Inline one level of recursive call of WriteToFlat for the common case of
cons
string list.
BUG=
TEST=
Please review this at http://codereview.chromium.org/9536011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
538986d2d1039d62df1bbaf385935b8c2d14eca0..bc0a82e6868ab16718f6c71451bf24e355134e61
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6862,10 +6862,21 @@ void String::WriteToFlat(String* src,
// Left hand side is longer. Recurse over right.
if (to > boundary) {
String* second = cons_string->second();
- WriteToFlat(second,
- sink + boundary - from,
- 0,
+ // When repeatedly appending to a string, we get a cons string
that
+ // is unbalanced to the left, a list, essentially. We inline
the
+ // common case of sequential ascii right child.
+ if (to - boundary == 1) {
+ sink[boundary - from] =
static_cast<sinkchar>(second->Get(0));
+ } else if (second->IsSeqAsciiString()) {
+ CopyChars(sink + boundary - from,
+ SeqAsciiString::cast(second)->GetChars(),
to - boundary);
+ } else {
+ WriteToFlat(second,
+ sink + boundary - from,
+ 0,
+ to - boundary);
+ }
to = boundary;
}
source = first;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
