http://codereview.chromium.org/9372063/diff/7001/src/mips/assembler-mips.cc File src/mips/assembler-mips.cc (right):
http://codereview.chromium.org/9372063/diff/7001/src/mips/assembler-mips.cc#newcode853 src/mips/assembler-mips.cc:853: bool Assembler::can_use_relative_load(RelocInfo::Mode rmode) { This should be called CanUseRelativeLoad http://codereview.chromium.org/9372063/diff/7001/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): http://codereview.chromium.org/9372063/diff/7001/src/mips/code-stubs-mips.cc#newcode7055 src/mips/code-stubs-mips.cc:7055: RelocInfo::CODE_TARGET), CONSTANT_SIZE); This line is incorrectly indented. http://codereview.chromium.org/9372063/diff/7001/src/mips/macro-assembler-mips.cc File src/mips/macro-assembler-mips.cc (right): http://codereview.chromium.org/9372063/diff/7001/src/mips/macro-assembler-mips.cc#newcode793 src/mips/macro-assembler-mips.cc:793: int32_t index = FindRootIndex(*(reinterpret_cast<Object**>(j.imm32_))); This will be too slow. I suggest you make it into ASSERT(FindRootIndex(...) == kInvalidRootIndex) and then fix the callers to use LoadRoot. http://codereview.chromium.org/9372063/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
