Addressed comments. Added new patch set. Rebased. Landed.
https://chromiumcodereview.appspot.com/9370019/diff/9001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://chromiumcodereview.appspot.com/9370019/diff/9001/src/arm/lithium-codegen-arm.cc#newcode4381 src/arm/lithium-codegen-arm.cc:4381: for (int i = 0; i < initial_map->inobject_properties(); i++) { On 2012/03/01 10:34:28, Vyacheslav Egorov wrote:
move this loop into the if. it's correct but a bit confusing when it's
outside. Done. https://chromiumcodereview.appspot.com/9370019/diff/9001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/9370019/diff/9001/src/ia32/lithium-codegen-ia32.cc#newcode4268 src/ia32/lithium-codegen-ia32.cc:4268: __ mov(FieldOperand(result, property_offset), undefined); On 2012/03/01 10:34:28, Vyacheslav Egorov wrote:
I't might be better to load undefined into a register (we have
scratch?) Done. https://chromiumcodereview.appspot.com/9370019/diff/9001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://chromiumcodereview.appspot.com/9370019/diff/9001/src/x64/lithium-codegen-x64.cc#newcode3999 src/x64/lithium-codegen-x64.cc:3999: __ Move(FieldOperand(result, property_offset), undefined); On 2012/03/01 10:34:28, Vyacheslav Egorov wrote:
consider pre loading undefined into a register (it's a huge 64-bit
constant). Done. https://chromiumcodereview.appspot.com/9370019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
