LGTM with comments addressed.
https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode562 src/messages.js:562: sourceUrl = SubString(source, matchInfo[CAPTURE(2)], matchInfo[CAPTURE(3)]); 80 col https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode565 src/messages.js:565: this.cachedNameOrSourceURL = sourceUrl || this.name; I think it's a bit more readable if you name the variable nameOrSourceURL and initialize it to this.name. That obviates the need for the use of the || operator in this way. https://chromiumcodereview.appspot.com/9564012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
