https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js File src/messages.js (right):
https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode562 src/messages.js:562: sourceUrl = SubString(source, matchInfo[CAPTURE(2)], matchInfo[CAPTURE(3)]); On 2012/03/02 12:06:32, danno wrote:
80 col
Done. https://chromiumcodereview.appspot.com/9564012/diff/1/src/messages.js#newcode565 src/messages.js:565: this.cachedNameOrSourceURL = sourceUrl || this.name; On 2012/03/02 12:06:32, danno wrote:
I think it's a bit more readable if you name the variable
nameOrSourceURL and
initialize it to this.name. That obviates the need for the use of the
||
operator in this way.
Done. https://chromiumcodereview.appspot.com/9564012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
