lgtm
https://chromiumcodereview.appspot.com/9584006/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/9584006/diff/1/src/hydrogen-instructions.cc#newcode1460 src/hydrogen-instructions.cc:1460: // ==, === and != have special handling of undefined, specifically undeifned s/undeifned/undefined https://chromiumcodereview.appspot.com/9584006/diff/1/src/hydrogen-instructions.cc#newcode1467 src/hydrogen-instructions.cc:1467: // See v8:1434 I'd also refer to the corresponding sections in the ES5 spec (11.9.3, 11.8.5) and use the same terms "relational comparison" and "equality comparison". https://chromiumcodereview.appspot.com/9584006/diff/1/src/hydrogen-instructions.cc#newcode1468 src/hydrogen-instructions.cc:1468: if (!Token::IsOrderedCompareOp(token_)) { maybe rename to IsRelationalCompareOp. https://chromiumcodereview.appspot.com/9584006/diff/1/src/ia32/ic-ia32.cc File src/ia32/ic-ia32.cc (right): https://chromiumcodereview.appspot.com/9584006/diff/1/src/ia32/ic-ia32.cc#newcode1730 src/ia32/ic-ia32.cc:1730: JavaScriptFrame::PrintTop(stdout, false, true); Leftover from debugging? https://chromiumcodereview.appspot.com/9584006/diff/1/test/mjsunit/comparison-ops-and-undefined.js File test/mjsunit/comparison-ops-and-undefined.js (right): https://chromiumcodereview.appspot.com/9584006/diff/1/test/mjsunit/comparison-ops-and-undefined.js#newcode44 test/mjsunit/comparison-ops-and-undefined.js:44: assertFalse(less_2(.5, .5)); You could compress this into a helper function test_helper(fun, b1, b2, b3, b4) { assertEquals(b1, fun(.5, .5)); assertEquals(b2, fun(.5, undefined)); assertEquals(b3, fun(undefined, .5)); assertEquals(b4, fun(undefined, undefined)); } and call it here like test_helper(less_2, false, false, false, false); Then it becomes also easy to add tests for different typefeedback in addition to heap numbers (.5, .5): smis, int32, undefined. https://chromiumcodereview.appspot.com/9584006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
