My mistake, I overlooked that it actually clears those flags. LGTM from what I can tell. But since this also touches code not only for MinGW, but also for MSVC, I'll have to test that patch tomorrow when I am in the office before actually committing. I hope that's alright.
Yang On Sun, Mar 4, 2012 at 11:50 AM, <[email protected]> wrote: > The calls to _set_abort_behavior already prevent the abort message from > being > printed and crash dialog from showing. My change does the same but also > works > with MinGW and older versions of MSVC that don't support > _set_abort_behaviour. > > https://chromiumcodereview.**appspot.com/9601002/<https://chromiumcodereview.appspot.com/9601002/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
