Revision: 10916 Author: [email protected] Date: Mon Mar 5 01:52:14 2012 Log: Simplify silent abort by raising SIGABRT directly.
Review URL: https://chromiumcodereview.appspot.com/9597012 Patch from Jonathan Liu <[email protected]>. http://code.google.com/p/v8/source/detail?r=10916 Modified: /branches/bleeding_edge/src/platform-win32.cc /branches/bleeding_edge/src/win32-headers.h ======================================= --- /branches/bleeding_edge/src/platform-win32.cc Mon Mar 5 00:17:16 2012 +++ /branches/bleeding_edge/src/platform-win32.cc Mon Mar 5 01:52:14 2012 @@ -967,12 +967,8 @@ void OS::Abort() { if (!IsDebuggerPresent()) { -#ifdef _MSC_VER // Make the MSVCRT do a silent abort. - _set_abort_behavior(0, _WRITE_ABORT_MSG); - _set_abort_behavior(0, _CALL_REPORTFAULT); -#endif // _MSC_VER - abort(); + raise(SIGABRT); } else { DebugBreak(); } ======================================= --- /branches/bleeding_edge/src/win32-headers.h Sun Mar 4 23:55:27 2012 +++ /branches/bleeding_edge/src/win32-headers.h Mon Mar 5 01:52:14 2012 @@ -56,6 +56,7 @@ #include <windows.h> #ifdef V8_WIN32_HEADERS_FULL +#include <signal.h> // For raise(). #include <time.h> // For LocalOffset() implementation. #include <mmsystem.h> // For timeGetTime(). #ifdef __MINGW32__ @@ -78,7 +79,7 @@ #ifndef __MINGW32__ #include <wspiapi.h> #endif // __MINGW32__ -#include <process.h> // for _beginthreadex() +#include <process.h> // For _beginthreadex(). #include <stdlib.h> #endif // V8_WIN32_HEADERS_FULL -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
