http://codereview.chromium.org/9600013/diff/1/src/objects.h File src/objects.h (right):
http://codereview.chromium.org/9600013/diff/1/src/objects.h#newcode7937 src/objects.h:7937: Object* get(AccessorComponent component) { On 2012/03/05 11:56:30, Michael Starzinger wrote:
If you plan on extending AccessorComponent later (e.g. by
ACCESSOR_NONE), it
might be good to have the following assertion in these two functions.
Your call.
ASSERT(component == ACCESSOR_GETTER || component == ACCESSOR_SETTER);
Given C++'s lovely implicit conversions, I think the ASSERT here and in set below are a good idea. Done. http://codereview.chromium.org/9600013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
