Reviewers: Michael Starzinger,
Description:
Ensure that inner pseudo-chunks are correctly initialized in
FreeQueuedChunks.
Fields introduced with guarding code space pages (area_start_, area_end_)
were
not correctly handled which lead to errors in StoreBuffer filtering.
[email protected]
TEST=mozilla/data/js1_5/GC/regress-203278-2.js
Please review this at https://chromiumcodereview.appspot.com/9600020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
M src/spaces.h
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
27571cfd5a6e874265b211b4f0579be47589e6cf..82e0965e9f83dcfefc8327099041a7403b22e29c
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -6918,14 +6918,18 @@ void Heap::FreeQueuedChunks() {
// pieces and initialize size, owner and flags field of every piece.
// If FromAnyPointerAddress encounters a slot that belongs to one of
// these smaller pieces it will treat it as a slot on a normal Page.
+ Address chunk_end = chunk->address() + chunk->size();
MemoryChunk* inner = MemoryChunk::FromAddress(
chunk->address() + Page::kPageSize);
- MemoryChunk* inner_last = MemoryChunk::FromAddress(
- chunk->address() + chunk->size() - 1);
+ MemoryChunk* inner_last = MemoryChunk::FromAddress(chunk_end - 1);
while (inner <= inner_last) {
// Size of a large chunk is always a multiple of
// OS::AllocateAlignment() so there is always
// enough space for a fake MemoryChunk header.
+ Address area_end = Min(inner->address() + Page::kPageSize,
chunk_end);
+ // Guard against overflow.
+ if (area_end < inner->address()) area_end = chunk_end;
+ inner->SetArea(inner->address(), area_end);
inner->set_size(Page::kPageSize);
inner->set_owner(lo_space());
inner->SetFlag(MemoryChunk::ABOUT_TO_BE_FREED);
Index: src/spaces.h
diff --git a/src/spaces.h b/src/spaces.h
index
599e9dd6fabdbafbcea14ba1a69082fc8018077e..75ca53444ab2dd4516ce7787ac99aa427dbf3bf0
100644
--- a/src/spaces.h
+++ b/src/spaces.h
@@ -506,6 +506,11 @@ class MemoryChunk {
size_ = size;
}
+ void SetArea(Address area_start, Address area_end) {
+ area_start_ = area_start;
+ area_end_ = area_end;
+ }
+
Executability executable() {
return IsFlagSet(IS_EXECUTABLE) ? EXECUTABLE : NOT_EXECUTABLE;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
