Addressed comments. Added new patch set.

https://chromiumcodereview.appspot.com/9615005/diff/1/src/unicode.cc
File src/unicode.cc (right):

https://chromiumcodereview.appspot.com/9615005/diff/1/src/unicode.cc#newcode750
src/unicode.cc:750: case 5: return LookupPredicate(kNumberTable5,
On 2012/03/06 09:31:57, Erik Corry wrote:
I understand that the data has changed, but why have more tables been
added.

As discussed offline: The large unicode table is split into chunks, the
chunk index is defined by "int chunk_index = c >> 13". There just was
nothing in the chunk with index 5 before, now there is.

https://chromiumcodereview.appspot.com/9615005/diff/1/src/unicode.h
File src/unicode.h (right):

https://chromiumcodereview.appspot.com/9615005/diff/1/src/unicode.h#newcode1
src/unicode.h:1: // Copyright 2012 the V8 project authors. All rights
reserved.
On 2012/03/06 09:31:57, Erik Corry wrote:
This seems wrong

Done.

https://chromiumcodereview.appspot.com/9615005/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to