Reviewers: fschneider,
Description:
Fix signed / unsigned warnings for ?: operators reported by Xcode 4.x clang
compiler.
The patch is based on the report provided by github user Zakay.
BUG=none
TEST=none
Please review this at https://chromiumcodereview.appspot.com/9592030/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/api.cc
M src/hydrogen-instructions.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
4498286916238f6ea009c1a3a0ce9124eb5e6cc4..6de212b97f1762ce3f697f271744caf5dc2152d4
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -525,7 +525,8 @@ Extension::Extension(const char* name,
int source_length)
: name_(name),
source_length_(source_length >= 0 ?
- source_length : (source ? strlen(source) : 0)),
+ source_length :
+ (source ? static_cast<int>(strlen(source)) : 0)),
source_(source, source_length_),
dep_count_(dep_count),
deps_(deps),
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
1069684dbf3a972ed6cbc60e238531458aa3d0a1..f7391dd33d0842e8eaab1121df1708597ca246b5
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -1348,12 +1348,13 @@ void HBinaryOperation::PrintDataTo(StringStream*
stream) {
Range* HBitwise::InferRange(Zone* zone) {
if (op() == Token::BIT_XOR) return HValue::InferRange(zone);
+ const int32_t kDefaultMask = static_cast<int32_t>(0xffffffff);
int32_t left_mask = (left()->range() != NULL)
? left()->range()->Mask()
- : 0xffffffff;
+ : kDefaultMask;
int32_t right_mask = (right()->range() != NULL)
? right()->range()->Mask()
- : 0xffffffff;
+ : kDefaultMask;
int32_t result_mask = (op() == Token::BIT_AND)
? left_mask & right_mask
: left_mask | right_mask;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
