Reviewers: Yang,

Description:
Simplify MSVCRT silent abort by raising SIGABRT directly

Contributed by [email protected]

BUGS=
TEST=

Please review this at https://chromiumcodereview.appspot.com/9601002/

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
  M     src/platform-win32.cc
  M     src/win32-headers.h


Index: src/platform-win32.cc
===================================================================
--- src/platform-win32.cc       (revision 10912)
+++ src/platform-win32.cc       (working copy)
@@ -942,12 +942,8 @@

 void OS::Abort() {
   if (!IsDebuggerPresent()) {
-#ifdef _MSC_VER
     // Make the MSVCRT do a silent abort.
-    _set_abort_behavior(0, _WRITE_ABORT_MSG);
-    _set_abort_behavior(0, _CALL_REPORTFAULT);
-#endif  // _MSC_VER
-    abort();
+    raise(SIGABRT);
   } else {
     DebugBreak();
   }
Index: src/win32-headers.h
===================================================================
--- src/win32-headers.h (revision 10912)
+++ src/win32-headers.h (working copy)
@@ -56,6 +56,7 @@
 #include <windows.h>

 #ifdef V8_WIN32_HEADERS_FULL
+#include <signal.h>  // For raise
 #include <time.h>  // For LocalOffset() implementation.
 #include <mmsystem.h>  // For timeGetTime().
 #ifdef __MINGW32__


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to