http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc File src/runtime.cc (left):
http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc#oldcode4324 src/runtime.cc:4324: On 2012/03/07 12:49:14, Michael Starzinger wrote:
Please leave this empty line in (or at least keep layout in sync with Runtime_DefineOrRedefineDataProperty). I cleaned it up a month ago.
Done. http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc#newcode4318 src/runtime.cc:4318: static bool IsValidAccessor(Object* obj) { On 2012/03/07 12:49:14, Michael Starzinger wrote:
Since this is only used as part of an assertion, I would prefer to
have the
condition inline instead of in a function.
As discussed offline, it's OK to keep this funtion, because RUNTIME_ASSERT uses its argument even in release mode. http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc#newcode4334 src/runtime.cc:4334: CONVERT_ARG_HANDLE_CHECKED(String, name, 1); On 2012/03/07 12:49:14, Michael Starzinger wrote:
Is there a particular reason you handlified the name (and not the
getter and
setter)?
The Object class was missing an IsObject predicate, which I added, so we can consistently use the CONVERT_ARG_HANDLE_CHECKED macro now. http://codereview.chromium.org/9616016/diff/4001/src/runtime.cc#newcode4349 src/runtime.cc:4349: getter = FixedArray::cast(array->elements())->get(GETTER_INDEX); On 2012/03/07 12:49:14, Michael Starzinger wrote:
I assume that this goes away once the above TODO is addressed? Then I
am fine
with this intermediate step.
Yes, this will vanish, it is just a temporary C++ re-write of the previous corresponding JavaScript code. http://codereview.chromium.org/9616016/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
