LGTM.
https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/9608006/diff/1/src/heap.h#newcode1046 src/heap.h:1046: static const int kAbortIncrementalMarkingMask = 4; Consider these flags: static const int kSweepPreciselyMask = 1; static const int kMakeHeapIterableMask = kSweepPreciselyMask | kAbortIncrementalMarkingMask; https://chromiumcodereview.appspot.com/9608006/diff/1/src/mark-compact-inl.h File src/mark-compact-inl.h (right): https://chromiumcodereview.appspot.com/9608006/diff/1/src/mark-compact-inl.h#newcode52 src/mark-compact-inl.h:52: Heap::kMakeHeapIterableMask)) != 0); If kMakeHeapIterableMask implies abort_incremental_marking_, wouldn't it be cleaner to have (kMakeHeapIterableMask & kAbortIncrementalMarkingMask) == kAbortIncrementalMarkingMask ? https://chromiumcodereview.appspot.com/9608006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
