LGTM if comments are addressed.

http://codereview.chromium.org/9307083/diff/2001/src/date.js
File src/date.js (right):

http://codereview.chromium.org/9307083/diff/2001/src/date.js#newcode674
src/date.js:674: // SET_DATE_LOCAL(this, t);
Commented code here and below.

http://codereview.chromium.org/9307083/diff/2001/src/objects-printer.cc
File src/objects-printer.cc (right):

http://codereview.chromium.org/9307083/diff/2001/src/objects-printer.cc#newcode679
src/objects-printer.cc:679: weekdays[weekday()->IsSmi()?
Smi::cast(weekday())->value() + 1 : -1],
if weekday is not a Smi, the index should be 0 not -1

http://codereview.chromium.org/9307083/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to