https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc File src/ast.cc (right):
https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc#newcode1148 src/ast.cc:1148: } else { On 2012/03/08 16:51:39, rossberg wrote:
Nit: indentation.
Done. https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h#newcode1252 src/ast.h:1252: Handle<String> s2 = reinterpret_cast<Literal*>(literal2)->ToString(); On 2012/03/08 16:51:39, rossberg wrote:
Could be static_cast.
Although the real difference between those casts in the presence of void* is not totally clear to me, I'll switch to static_cast. https://chromiumcodereview.appspot.com/9639011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
