Reviewers: fschneider,
Message:
Please take a look.
Description:
Revert r10435 and r10923 because of failures.
r10435 CL: http://codereview.chromium.org/9195005
r10923 CL: https://chromiumcodereview.appspot.com/9601010
[email protected]
Please review this at https://chromiumcodereview.appspot.com/9653025/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
M src/hydrogen.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
4b5ae580b6b63df3ec9f11c82bd6c82ba456dd55..c62e18d4017c2a1577987d4d7bd15bc2dea11380
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -168,7 +168,7 @@ DEFINE_bool(use_osr, true, "use on-stack replacement")
DEFINE_bool(trace_osr, false, "trace on-stack replacement")
DEFINE_int(stress_runs, 0, "number of stress runs")
DEFINE_bool(optimize_closures, true, "optimize closures")
-DEFINE_bool(inline_construct, true, "inline constructor calls")
+DEFINE_bool(inline_construct, false, "inline constructor calls")
DEFINE_int(loop_weight, 1, "loop weight for representation inference")
DEFINE_bool(optimize_for_in, true,
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
18a62c689bd3c5bea3ee9733923bbf4e46367205..fe23a14765ad7eb519fdef030791db3e38114024
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -6654,15 +6654,6 @@ static bool IsLiteralCompareNil(HValue* left,
}
-static bool IsLiteralCompareBool(HValue* left,
- Token::Value op,
- HValue* right) {
- return op == Token::EQ_STRICT &&
- ((left->IsConstant() &&
HConstant::cast(left)->handle()->IsBoolean()) ||
- (right->IsConstant() &&
HConstant::cast(right)->handle()->IsBoolean()));
-}
-
-
void HGraphBuilder::VisitCompareOperation(CompareOperation* expr) {
ASSERT(!HasStackOverflow());
ASSERT(current_block() != NULL);
@@ -6710,12 +6701,6 @@ void
HGraphBuilder::VisitCompareOperation(CompareOperation* expr) {
if (IsLiteralCompareNil(left, op, right, f->null_value(), &sub_expr)) {
return HandleLiteralCompareNil(expr, sub_expr, kNullValue);
}
- if (IsLiteralCompareBool(left, op, right)) {
- HCompareObjectEqAndBranch* result =
- new(zone()) HCompareObjectEqAndBranch(left, right);
- result->set_position(expr->position());
- return ast_context()->ReturnControl(result, expr->id());
- }
if (op == Token::INSTANCEOF) {
// Check to see if the rhs of the instanceof is a global function not
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
