First round
http://codereview.chromium.org/9616014/diff/2001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/9616014/diff/2001/src/hydrogen-instructions.h#newcode2054 src/hydrogen-instructions.h:2054: class HCheckMapSet: public HTemplateInstruction<1> { Please merge with HCheckMap as discussed http://codereview.chromium.org/9616014/diff/2001/src/hydrogen-instructions.h#newcode2076 src/hydrogen-instructions.h:2076: virtual bool DataEquals(HValue* other) { Fast case single maps by just comparing b->map_set() == map_set() http://codereview.chromium.org/9616014/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/9616014/diff/2001/src/hydrogen.cc#newcode3875 src/hydrogen.cc:3875: static bool ComputeStoredField(Handle<Map> type, Rename to something like ComputeLoadStoreField http://codereview.chromium.org/9616014/diff/2001/src/hydrogen.cc#newcode3979 src/hydrogen.cc:3979: for (int i = 0; i < types->length() && count < kMaxStorePolymorphism; ++i) { kMaxStorePolymorphism seems to be inappropriately named http://codereview.chromium.org/9616014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
