Reviewers: rossberg, ulan,
Message:
We're currently trying to get chromium's unit_tests target to build for the
Android configuration. However, v8_shell fails to link without this change.
It
appears to be a requirement of the linker included in the Android toolchain.
Description:
Add explicit dependency on v8_base
This is necessary in order to link v8_shell (for host) with the Android
toolchain.
Without it, the line in the makefile is:
$(builddir)/v8_shell: LD_INPUTS := $(OBJS)
$(obj).host/v8/tools/gyp/libv8_snapshot.a
$(obj).host/v8/tools/gyp/libv8_base.a
Now it appears as:
$(builddir)/v8_shell: LD_INPUTS := $(OBJS)
$(obj).host/v8/tools/gyp/libv8_base.a
$(obj).host/v8/tools/gyp/libv8_snapshot.a
and it successfully links.
BUG=
TEST=
Please review this at https://chromiumcodereview.appspot.com/9668013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/gyp/v8.gyp
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
b8769510c85b49336f2eed69cdcb03dab961f1a7..e832892b1c94485b0be11c68a0ae8910fe9590d2
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -40,10 +40,16 @@
'toolsets': ['target'],
}],
['v8_use_snapshot=="true"', {
- 'dependencies': ['v8_snapshot'],
+ # The dependency on v8_base should come from a transitive
+ # dependency however the Android toolchain requires
libv8_base.a
+ # to appear before libv8_snapshot.a so it's listed
explicitly.
+ 'dependencies': ['v8_base', 'v8_snapshot'],
},
{
- 'dependencies': ['v8_nosnapshot'],
+ # The dependency on v8_base should come from a transitive
+ # dependency however the Android toolchain requires
libv8_base.a
+ # to appear before libv8_snapshot.a so it's listed
explicitly.
+ 'dependencies': ['v8_base', 'v8_nosnapshot'],
}],
['component=="shared_library"', {
'type': '<(component)',
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
