Revision: 10993
Author:   [email protected]
Date:     Fri Mar  9 14:11:16 2012
Log:      Fixed VFP detection through compiler defines.

BUG=http://code.google.com/p/v8/issues/detail?id=1996
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9669003
Patch from Rodolph Perfetta <[email protected]>.
http://code.google.com/p/v8/source/detail?r=10993

Modified:
 /branches/bleeding_edge/src/arm/assembler-arm.cc

=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.cc Fri Jan 13 05:09:52 2012 +++ /branches/bleeding_edge/src/arm/assembler-arm.cc Fri Mar 9 14:11:16 2012
@@ -66,11 +66,13 @@

 #ifdef __arm__
// If the compiler is allowed to use VFP then we can use VFP too in our code
-  // generation even when generating snapshots.  This won't work for cross
-  // compilation. VFPv3 implies ARMv7, see ARM DDI 0406B, page A1-6.
-#if defined(__VFP_FP__) && !defined(__SOFTFP__)
+  // generation even when generating snapshots. ARMv7 and hardware floating
+  // point support implies VFPv3, see ARM DDI 0406B, page A1-6.
+#if defined(CAN_USE_ARMV7_INSTRUCTIONS) && defined(__VFP_FP__) \
+    && !defined(__SOFTFP__)
   answer |= 1u << VFP3 | 1u << ARMv7;
-#endif  // defined(__VFP_FP__) && !defined(__SOFTFP__)
+#endif  // defined(CAN_USE_ARMV7_INSTRUCTIONS) && defined(__VFP_FP__)
+        // && !defined(__SOFTFP__)
 #endif  // def __arm__

   return answer;

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to