Revision: 11005
Author: [email protected]
Date: Mon Mar 12 03:35:50 2012
Log: Add explicit dependency on v8_base
This is necessary in order to link v8_shell (for host) with the Android
toolchain.
Without it, the line in the makefile is:
$(builddir)/v8_shell: LD_INPUTS := $(OBJS)
$(obj).host/v8/tools/gyp/libv8_snapshot.a
$(obj).host/v8/tools/gyp/libv8_base.a
Now it appears as:
$(builddir)/v8_shell: LD_INPUTS := $(OBJS)
$(obj).host/v8/tools/gyp/libv8_base.a
$(obj).host/v8/tools/gyp/libv8_snapshot.a
and it successfully links.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9668013
Patch from Yaron Friedman <[email protected]>.
http://code.google.com/p/v8/source/detail?r=11005
Modified:
/branches/bleeding_edge/tools/gyp/v8.gyp
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp Fri Mar 9 04:07:29 2012
+++ /branches/bleeding_edge/tools/gyp/v8.gyp Mon Mar 12 03:35:50 2012
@@ -40,10 +40,16 @@
'toolsets': ['target'],
}],
['v8_use_snapshot=="true"', {
- 'dependencies': ['v8_snapshot'],
+ # The dependency on v8_base should come from a transitive
+ # dependency however the Android toolchain requires
libv8_base.a
+ # to appear before libv8_snapshot.a so it's listed
explicitly.
+ 'dependencies': ['v8_base', 'v8_snapshot'],
},
{
- 'dependencies': ['v8_nosnapshot'],
+ # The dependency on v8_base should come from a transitive
+ # dependency however the Android toolchain requires
libv8_base.a
+ # to appear before libv8_snapshot.a so it's listed
explicitly.
+ 'dependencies': ['v8_base', 'v8_nosnapshot'],
}],
['component=="shared_library"', {
'type': '<(component)',
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
