lgtm
https://chromiumcodereview.appspot.com/9600009/diff/18001/src/handles.cc File src/handles.cc (right): https://chromiumcodereview.appspot.com/9600009/diff/18001/src/handles.cc#newcode952 src/handles.cc:952: while (failure) { Nit: this seems more natural as a do-while loop. https://chromiumcodereview.appspot.com/9600009/diff/18001/src/handles.h File src/handles.h (right): https://chromiumcodereview.appspot.com/9600009/diff/18001/src/handles.h#newcode173 src/handles.h:173: Nit: accidental extra newline? https://chromiumcodereview.appspot.com/9600009/diff/18001/src/unicode.h File src/unicode.h (right): https://chromiumcodereview.appspot.com/9600009/diff/18001/src/unicode.h#newcode121 src/unicode.h:121: if (code == kNoPreviousCharacter) return false; I still think this is implied by the bit masking below, but see that you may want to make it more explicit/robust. https://chromiumcodereview.appspot.com/9600009/diff/18001/src/unicode.h#newcode132 src/unicode.h:132: static const int kNoPreviousCharacter = -1; int32_t? https://chromiumcodereview.appspot.com/9600009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
