http://codereview.chromium.org/9690010/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/9690010/diff/1/src/ia32/codegen-ia32.cc#newcode114 src/ia32/codegen-ia32.cc:114: if (buffer == NULL || !V8::UseCrankshaft()) return &sqrt; Using !CpuFeatures::IsSupported(SSE2) here would guarantee consistency between runs with Crankshaft and without it on SSE2 platforms. http://codereview.chromium.org/9690010/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/9690010/diff/1/src/runtime.cc#newcode7444 src/runtime.cc:7444: // Convert -0 to +0. This comment refers to the last part of the ternary ? operator, not the whole statement. http://codereview.chromium.org/9690010/diff/1/src/runtime.cc#newcode7447 src/runtime.cc:7447: // Convert -0 to +0. See above. http://codereview.chromium.org/9690010/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/9690010/diff/1/src/x64/codegen-x64.cc#newcode111 src/x64/codegen-x64.cc:111: if (buffer == NULL || !V8::UseCrankshaft()) return &sqrt; To guarantee consistency between runs with and without "--nouse-crankshaft", it would be better to remove this check. x64 always has SSE. http://codereview.chromium.org/9690010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
