LGTM (with nits).
https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js File test/mjsunit/regress/regress-115452.js (right): https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode37 test/mjsunit/regress/regress-115452.js:37: assertEquals(1, this.foobl); Better use assertSame() here. https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode42 test/mjsunit/regress/regress-115452.js:42: assertEquals(1, this.foobl); Likewise. https://chromiumcodereview.appspot.com/9696035/diff/1/test/mjsunit/regress/regress-115452.js#newcode46 test/mjsunit/regress/regress-115452.js:46: eval("function foobl() {}"); Why do you test this twice? Isn't once sufficient? https://chromiumcodereview.appspot.com/9696035/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
