LGTM with one comment.
https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc#newcode12284 src/runtime.cc:12284: script->set_source(*source); Not sure if silent failure is the best thing to do. Maybe return isolate->ThrowIllegalOperation()? https://chromiumcodereview.appspot.com/9677043/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
