Agreed. The test are all pre-d8 typed array support and even
pre-OptimizeFunctionOnNextCall. However, I am going to save that for another CL,
since it's a chunk of refactoring that I don't want to couple with this fix.

On 2012/03/15 09:17:05, fschneider wrote:
It seems that the tests in test-api/PixelArray do not exercise the optimizing
compiler well enough.

I'd strongly prefer changing those tests so that they all hit the optimizing compiler (including the one extracted test case). The easiest is probably to
move them from cctest to a mjsunit test since we now have support for
allocating
typed arrays in d8.

LGTM, otherwise.


https://chromiumcodereview.appspot.com/9702027/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to