Reviewers: Erik Corry,
Description:
Switch Heap::RecordStats to use PagedSpace::SizeOfObjects instead of
PagedSpace::Size.
This would allow us to get more precise estimate of heap fragmentation on
OOM.
[email protected]
Please review this at https://chromiumcodereview.appspot.com/9700096/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
e6dd2a9657c7f81a7d5c186ad618d7f957eac8bc..be302acbee96113dd1f832b38dbc4afd6d31e15b
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -5625,15 +5625,15 @@ void Heap::RecordStats(HeapStats* stats, bool
take_snapshot) {
*stats->end_marker = HeapStats::kEndMarker;
*stats->new_space_size = new_space_.SizeAsInt();
*stats->new_space_capacity = static_cast<int>(new_space_.Capacity());
- *stats->old_pointer_space_size = old_pointer_space_->Size();
+ *stats->old_pointer_space_size = old_pointer_space_->SizeOfObjects();
*stats->old_pointer_space_capacity = old_pointer_space_->Capacity();
- *stats->old_data_space_size = old_data_space_->Size();
+ *stats->old_data_space_size = old_data_space_->SizeOfObjects();
*stats->old_data_space_capacity = old_data_space_->Capacity();
- *stats->code_space_size = code_space_->Size();
+ *stats->code_space_size = code_space_->SizeOfObjects();
*stats->code_space_capacity = code_space_->Capacity();
- *stats->map_space_size = map_space_->Size();
+ *stats->map_space_size = map_space_->SizeOfObjects();
*stats->map_space_capacity = map_space_->Capacity();
- *stats->cell_space_size = cell_space_->Size();
+ *stats->cell_space_size = cell_space_->SizeOfObjects();
*stats->cell_space_capacity = cell_space_->Capacity();
*stats->lo_space_size = lo_space_->Size();
isolate_->global_handles()->RecordStats(stats);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
