http://codereview.chromium.org/9702114/diff/1/src/lazy-instance.h File src/lazy-instance.h (right):
http://codereview.chromium.org/9702114/diff/1/src/lazy-instance.h#newcode107 src/lazy-instance.h:107: #if V8_HOST_ARCH_MIPS I'd prefer avoiding the platform-specific define. Is there a more general test about the target architecture that can determine if this is needed? Is it harmful to have this always present for GCC-based builds? http://codereview.chromium.org/9702114/diff/1/src/lazy-instance.h#newcode188 src/lazy-instance.h:188: // Note that the previous field, OnceType, is an AtomicWord which guarantees On 2012/03/16 12:24:30, Philippe wrote:
We noticed this issue and thought that we could temporarily rely on
the
AtomicWord field (once_) to guarantee the correct alignment. Does this
issue
apply to architectures other than MIPS? Should we always use the
alignof
attribute (with GCC)? You could probably update the comment here.
Thanks for fixing this.
Done. http://codereview.chromium.org/9702114/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
